Re: [PATCH] fixup! push: switch default from "matching" to "simple"

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 17, 2013, 20:48 UTC
Message-ID: <vpqy5a8wjjw.fsf@anie.imag.fr>
In-Reply-To: <7vhagwcyqf.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> Note that this has to further change if Ram's triangular push fix
> comes before 2.0.

I didn't follow precisely this topic. In any case, better have this in the patch, if only as a reminder that this part will need to be updated.

> I am not sure if these original two lines are necessary.  Wouldn't
> it more appropriate to just drop the "Without additional configuration"
> and go straight to "The default behaviour of this command..."?

I think it makes sense to avoid having to go through too many sections to understand the default behavior.

Right now, to know what "git push" does, the reader reads the DESCRIPTION and finds nothing, reads the <refspec>... part and does not see what happens when it's omitted, then see the EXAMPLE section

git push => see git push origin

git push origin => see push.default in git config --help

At least, keeping these lines, we avoid the last indirection.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/