Re: git grep: search whole tree by default?

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Oct 23, 2013, 20:43 UTC
Message-ID: <vpqy55jogzr.fsf@anie.imag.fr>
In-Reply-To: <87zjpzg592.fsf@mcs.anl.gov>

Jed Brown <jed@59A2.org> writes:

Show 20 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Jed Brown <jed@59A2.org> writes:
>>
>>> Junio C Hamano <gitster@pobox.com> writes:
>>>> I suspect that it would be too late for 2.0 we want to do sometime
>>>> early next year, though.
>>>
>>> How would you manage transition from the current behavior?  Warning
>>> people to explicitly use "." or ":/" during some interim period sounds
>>> worse than just switching the default behavior.
>>
>> "How would I"?
>>
>> You're asking that question only because you omitted too much from
>> the quote ;-)
>
> I meant that if the proposed migration plan were to be "just change it
> and people will learn" (because anything more gradual would actually be
> worse for users) then is it really too late for Git-2.0?

That may be an option. In the case of "git add -u", it was a bit more complicated, since a badly used "git add" somehow looses data (not very serious, you may only loos the index). So, saying after the fact "oh, by the way, I messed up the index" was not a very good transition plan.

In the case of "grep", I'm starting to get convinced that it's OK to do so, because the user can basically re-run grep with the right argument if needed.

The warning could be de-activable with an advice.* option.

Again, no strong opinion here, but that seems workable to me.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/