git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 2/2] status:introduce status.branch to enable --branch by default

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jun 11, 2013, 13:43 UTC
Message-ID
<vpqwqq03gr0.fsf@anie.imag.fr>
In-Reply-To
<1370957645-17905-2-git-send-email-Jorge-Juan.Garcia-Garcia@ensimag.imag.fr>
Jorge-Juan.Garcia-Garcia@ensimag.imag.fr writes:
> +test_expect_success '"status.branch=true" different from "--no-branch"' '
> +	git -c status.branch=true status -s >actual &&
> +	git status -s --no-branch  >expected_nobranch &&
Two nitpicks:
There are two spaces before >, there should be one.

If the first "git" command fails, then you fail to create expected_nobranch and the other tests fail too. Creating expected_nobranch before actual would solve this. You have the same issue in PATCH 1/2.

With or without these fixed,
Reviewed-by: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
(both patches)
-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: jorge-juan.garcia-garcia@ensimag.imag.frNext: Junio C Hamano
Message 3 of 5 in “status: introduce status.short to enable --short by default”
  1. 1/2 status: introduce status.short to enable --short by defaultjorge-juan.garcia-garcia@ensimag.imag.fr, Jun 11, 2013
  2. 2/2 status:introduce status.branch to enable --branch by defaultjorge-juan.garcia-garcia@ensimag.imag.fr, Jun 11, 2013
  3. Matthieu MoyJun 11, 2013
  4. Junio C HamanoJun 11, 2013
  5. Matthieu MoyJun 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.