Re: [PATCH v2] send-email: allow use of basic email list in --cc --to and --bcc

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 19, 2013, 11:51 UTC
Message-ID: <vpqwqpqjp3t.fsf@anie.imag.fr>
In-Reply-To: <1371641640-3897-1-git-send-email-Jorge-Juan.Garcia-Garcia@ensimag.imag.fr>

Jorge-Juan.Garcia-Garcia@ensimag.imag.fr writes:

> Changes since v1:
> [...]
>  - did not change the two regexp into one, because it's faster with two

(I find it strange to describe non-change in a list of changes)

I don't think speed is an argument here: it's a one-time operation and will be instantaneous for the user in any case.

Show 8 quoted lines

> +sub split_emails {
> +    my ($emails) = @_;
> +    my @split_list;
> +    if ($emails =~ /,/) {
> +	@split_list = split(/,/, $emails);
> +    } else {
> +	@split_list = $emails;
> +    }

Do you need this "if"? Wouldn't split do the right thing if $emails does not contain comma?

> +    # Removal of unwanted spaces
> +    for (my $j = 0; $j <= $#split_list; $j++) {

Sounds very un-perl-ish. Something like this maybe?

foreach $email (@emails) {
	$email =~ s/^\s+|\s+$//;
}

> +    return @split_list;
> +}

This is indented with tab/spaces mix. Please, use tabs only in Git's source.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/