Re: [PATCH v10 4/4] test-config: add tests for the config_set API

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jul 18, 2014, 21:52 UTC
Message-ID: <vpqwqba1gif.fsf@anie.imag.fr>
In-Reply-To: <xmqqzjg6mwhm.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 7 quoted lines

> Tanay Abhra <tanayabh@gmail.com> writes:
>
>> +test_expect_success 'proper error on non-existant files' '
>> +	echo "Error (-1) reading configuration file non-existant-file." >expect &&
>
> s/tant/tent/ perhaps?
> cf. http://en.wiktionary.org/wiki/non-existant

It seems so. My bad.

Show 9 quoted lines

>> +test_expect_success 'proper error on non-accessible files' '
>> +	chmod -r .git/config &&
>> +	test_when_finished "chmod +r .git/config" &&
>> +	echo "Error (-1) reading configuration file .git/config." >expect &&
>> +	test_expect_code 2 test-config configset_get_value foo.bar .git/config 2>actual &&
>> +	test_cmp expect actual
>> +'
>
> Doesn't this one need some prerequisite?

My bad too ;-). There should have been SANITY,POSIXPERM I guess (Tanay: search "prereq" in t/README if you don't see what we're talking about).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/