Re: [PATCH v2] wt-status: correct and simplify check for detached HEAD
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Nov 25, 2015, 16:21 UTC
- Message-ID
- <vpqvb8qt5hr.fsf@anie.imag.fr>
- In-Reply-To
- <5655C14A.1060308@web.de>
René Scharfe <l.s.r@web.de> writes:
Show 23 quoted lines
> diff --git a/wt-status.c b/wt-status.c
> index 435fc28..ced53dd 100644
> --- a/wt-status.c
> +++ b/wt-status.c
> @@ -1317,15 +1317,14 @@ static int grab_1st_switch(unsigned char *osha1, unsigned char *nsha1,
> target += strlen(" to ");
> strbuf_reset(&cb->buf);
> hashcpy(cb->nsha1, nsha1);
> - for (end = target; *end && *end != '\n'; end++)
> - ;
> - if (!memcmp(target, "HEAD", end - target)) {
> + end = strchrnul(target, '\n');
> + strbuf_add(&cb->buf, target, end - target);
> + if (!strcmp(cb->buf.buf, "HEAD")) {
> /* HEAD is relative. Resolve it to the right reflog entry. */
> + strbuf_reset(&cb->buf);
> strbuf_addstr(&cb->buf,
> find_unique_abbrev(nsha1, DEFAULT_ABBREV));
> - return 1;
> }
> - strbuf_add(&cb->buf, target, end - target);
> return 1;
> }Indeed, the code is much simpler like this than with the previous attempts. Looks all right to me.
-- Matthieu Moy http://www-verimag.imag.fr/~moy/