Re: Best way to apply textconv to a working tree file

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 1, 2010, 17:30 UTC
Message-ID: <vpqtypmaceb.fsf@bauges.imag.fr>
In-Reply-To: <20100601171359.GD9702@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

>> git cat-file --textconv <blob-sha1>            # Run textconv on blob
>
> This wouldn't work. The textconv is defined by the diff driver, which is
> associated with a pathname,

Right, forget it.

Show 5 quoted lines

>> git cat-file --textconv <tree-sha1>:<filename> # Run textconv on file
>>                                                # (in object database)
>
> This could work in theory, but will not be as easy to implement as you
> hope.

Actually, Clément has already hit the issue.

> complex as "HEAD@{12:00 yesterday}:foo.c"

_that_ is the actual example I was looking for ;-) (with a : inside the pathname to make sure you can't search it from the right).

> It would be nice if there was some way in the get_sha1* functions to
> save some context, like tree context and filename. This would be helpful
> for something like "git show HEAD:foo.txt", which probably should be
> respecting autocrlf and smudge/clean filters.

Yup. The code to do the parsing is already there, it "just" needs to be made available through a clean API.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/