Re: [PATCH 2/2] pull: clarify the large && { ... } form

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 14, 2013, 09:09 UTC
Message-ID: <vpqr4g5kqht.fsf@anie.imag.fr>
In-Reply-To: <1371200178-9927-3-git-send-email-artagnon@gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

> -test true = "$rebase" && {
> +if test true = "$rebase"; then

Use a newline, not a ';'.

See CodingGuideLines:

 - Do not write control structures on a single line with semicolon.
   "then" should be on the next line for if statements, and "do"
   should be on the next line for "while" and "for".

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/