Re: [RFC/ PATCH 1/5] tree-walk: do not stop when an error is detected

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 9, 2010, 20:54 UTC
Message-ID: <vpqpr00x6z0.fsf@bauges.imag.fr>
In-Reply-To: <AANLkTimSYHX1yXEGif6Mk1kadUy1QSHTQByiyuFsqe8r@mail.gmail.com>

Diane Gasselin <diane.gasselin@ensimag.imag.fr> writes:

Show 10 quoted lines

>> A small worry is if we have some codepath that uses this function like
>> this:
>>
>>    if (traverse trees finishes successfully) {
>>        be happy, all is well;
>>    } else {
>>        attempt a different strategy to achieve
>>        what we wanted to with traverse trees, if
>>        it worked fine.
>>    }

[...]

> Seems pretty fair.
> Can I add in this case an option to git pull and git merge to specify
> that we do want to collect all the errors?

I don't think this should ever been exposed in the user interface. It may be interesting to add this in the API (an extra argument letting the caller decide whether to fail early or not), but the user running "git pull" normally expects it to succeed, and can clearly accept that a failure takes as much time as a success, especially when the better error message lets him save a few tens of seconds, if not minutes.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/