git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] Do not let lstree output recursively when a directory whose name is a prefix of the others is given in the path list.

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Sep 9, 2010, 21:30 UTC
Message-ID
<vpqocc6vc41.fsf@bauges.imag.fr>
In-Reply-To
<1284056514-4935-1-git-send-email-davi.reis@gmail.com>
davi.reis@gmail.com writes:
> Subject: Re: [PATCH 1/2] Do not let lstree output recursively when a directory whose name is a prefix of the others is give

Don't try to put everything in the subject line. The subject line should be < 80 characters (fit in a standard terminal), and it's best if commands like "git log --oneline" & friends can show it without truncating it, hence, ~50-60 characters is good.

What about
ls-tree: do not recurse when a directory is a prefix of another
<then, a more detailed description, after a blank line>

(I don't know the code of ls-tree, and I don't really understand either the bug or the fix by reading this. A good commit message help people to get convinced that your code is good)

> From: Davi Reis <davi@davi-macbookpro.local>

If you use the same identifier for the commit and when you send the email, you'll get rid of this « From » in the body. I don't think you want this davi-macbookpro.local to appear publicly indeed.

You don't have a Signed-Off-By:, please read Documentation/SubmittingPatches to see how to add it and what it means.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Davi Reis
Message 5 of 5 in “Do not let lstree output recursively when a directory whose name is a prefix of the others is given in the path list.”
  1. 1/2 Do not let lstree output recursively when a directory whose name is a prefix of the others is given in the path list.davi.reis@gmail.com, Sep 9, 2010
  2. 2/2 Added test from David Glasser.davi.reis@gmail.com, Sep 9, 2010
  3. Matthieu MoySep 9, 2010
  4. Davi ReisSep 9, 2010
  5. Matthieu MoySep 9, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.