Re: [PATCH v2] ls-files: Add eol diagnostics

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Nov 1, 2015, 18:40 UTC
Message-ID: <vpqmvuxzhot.fsf@anie.imag.fr>
In-Reply-To: <5635D0B1.9040800@gmail.com>

Sebastian Schuberth <sschuberth@gmail.com> writes:

> However, the commit message says "to check if text files are stored
> normalized in the *repository*", yet the output refers to the index /
> cache. Is there a (potential) difference between line endings in the
> index and repo?

There is when you have staged changes that are not commited yet.

> Any I find it a bit confusing to refer to the index where, as e.g. for
> a freshly cloned repo the index should be empty,

No it is not. The index is a complete snapshot of your working tree. When you have no uncommited staged changes, the index contains all files that are in HEAD. Most commands show you _changes_ in the index (wrt HEAD or wrt the working tree), but the index itself contain all files.

> Long story short, how about consistently talking about line endings in
> the repo, and also using "repo" instead of "ca" here?

I don't think this is a good idea. One typical use-case for the feature would probably be:

1) wtf, there's something wrong with my line endings, let's fix this.

2) tweak .gitattributes, try to get everything right

3) prepare a commit to apply the new settings to the repository, play
   with "git add", "dos2unix" and friends.

4) check that it's OK

5) "git commit"

At stage 4), you really want to see the content of the index, because your HEAD is still broken.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/