Re: [PATCH/RFC] git-commit: add a commit.verbose config variable

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Feb 25, 2016, 21:27 UTC
Message-ID: <vpqmvqo1nx7.fsf@anie.imag.fr>
In-Reply-To: <56CFBF19.6040004@zoho.com>

Pranit Bauva <pranit.bauva@zoho.com> writes:

> From c273a02fc9cab9305cedf6e37422e257a1cc3b1e Mon Sep 17 00:00:00 2001
> From: Pranit Bauva <pranit.bauva@zoho.com>
> Date: Fri, 26 Feb 2016 07:14:18 +0530
> Subject: [PATCH/RFC] git-commit: add a commit.verbose config variable

These should not appear in the body of your message, but they should be the actual headers of your email. Try sending such message to yourself, and compare with what you see on the list.

Using "git send-email" normally does the right thing. You may want to look at https://submitgit.herokuapp.com/ too.

> The variable `verbose` is changed instead of `s.verbose` as the method
> run_status() updates the `s.verbose` with the value of `verbose`. So in
> this way the change is reflected in both of them.

The commit message should not try to rephrase what the patch aleady says.

>     This is a patch for the microproject of GSOC 2016. I have done the change
>     under careful consideration of where to place the line. I have to yet write
>     the tests for this.

If you know you haven't finished, you may use WIP (work in progress) instead of RFC in the title.

> +commit.verbose::
> +	A boolean to specify whether to always include the verbose option

Boolean is usually written with a capital letter.

> +	with git-config.

Did you mean "git commit"?

> +	of the commit message. If this option is used always, it can

"If this option is used always" does not sound right. I'd write "To activate this option permanently, ..."

> +	be set in the git-config with the boolean variable `commit.verbose`.

"the git-config" is not proper English. You mean "a configuration file". I'd write "the configuration variable `commit.verbose` can be set to true".

Show 7 quoted lines

> --- a/builtin/commit.c
> +++ b/builtin/commit.c
> @@ -1644,6 +1644,8 @@ int cmd_commit(int argc, const char **argv, const char *prefix)
>  	status_format = STATUS_FORMAT_NONE; /* Ignore status.short */
>  	s.colopts = 0;
>  
> +	git_config_get_bool("commit.verbose", &verbose);

Doesn't this override any value that --verbose or --no-verbose may have set before?

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/