git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Formatting problem send_mail in version 2.10.0

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Oct 13, 2016, 05:37 UTC
Message-ID
<vpqmvi8n71g.fsf@anie.imag.fr>
In-Reply-To
<20161012231321.ar2csdmvhdya2q7r@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
>   2. Drop everything after the trailing ">". This gives a valid rfc2822
>      cc, and people can pick the "# 4.8" from the cc line in the body.

That would work for me, but it's inconsistent with Mail::Address and I'd really like to avoid having a behavior depending on libraries installed.

Plus, consistency with Mail::Address gives us consistency with any other program using Mail::Address.

Show 10 quoted lines
>   3. Rewrite
>
>        A <B@C> D
>
>      into
>
>        A D <B@C>
>
>      regardless of what is in "D". This retains the information in the
>      rfc2822 cc.
There's another one I considered:
   4. Consider '#.*' as a comment when parsing trailers (but not in
      other places where we parse addresses)
This is much harder to define properly because of
Cc: "Foo # Bar" <email@example.com>

=> we'd need to handle the ".*" syntax when stripping comments. And again, that wouldn't be consistent with Mail::Address.

So, I ended up implementing 3., which actually isn't hard, and gives code IMHO cleaner than it used to be.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Jeff KingNext: Matthieu Moy
Message 18 of 24 in “Formatting problem send_mail in version 2.10.0”
  1. Larry FingerOct 10, 2016
  2. Jeff KingOct 10, 2016
  3. Jeff KingOct 10, 2016
  4. Larry FingerOct 10, 2016
  5. Jeff KingOct 10, 2016
  6. Matthieu MoyOct 11, 2016
  7. Larry FingerOct 11, 2016
  8. Matthieu MoyOct 11, 2016
  9. Larry FingerOct 12, 2016
  10. Matthieu MoyOct 12, 2016
  11. Larry FingerOct 12, 2016
  12. Matthieu MoyOct 12, 2016
  13. Larry FingerOct 12, 2016
  14. Matthieu MoyOct 12, 2016
  15. Larry FingerOct 12, 2016
  16. Junio C HamanoOct 12, 2016
  17. Jeff KingOct 12, 2016
  18. Matthieu MoyOct 13, 2016
  19. parse_mailboxes: accept extra text after <...> addressMatthieu Moy, Oct 13, 2016
  20. Kevin DaudtOct 13, 2016
  21. Matthieu MoyOct 13, 2016
  22. Matthieu MoyOct 13, 2016
  23. Junio C HamanoOct 14, 2016
  24. Jeff KingOct 11, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.