git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] git gui blame fails for multi-word textconv filter

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Aug 5, 2010, 09:59 UTC
Message-ID
<vpqlj8l2xd5.fsf@bauges.imag.fr>
In-Reply-To
<4C59FBD5.5090209@ensimag.imag.fr>
Clément Poulain <clement.poulain@ensimag.imag.fr> writes:
> I wonder if spaces can be the reason of this. Looks like Tcl is
> looking for an executable called "run-mailcap --action=cat", and
> doesn't distinguish path from options.

Yes, and it does this because we asked it to do so. Whitespace interpretation is done by the shell, and there's no shell involved here.

> I do not have much experience with Tcl, so I can't figure out how to
> solve that. Some help would be appreciate :-)

Patch follows. It just runs the textconv using a shell, which does whitespace interpretation (and more if needed). Tested with

textconv=odt2txt --width=40
and a file containing whitespaces.
-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Clément PoulainNext: Matthieu Moy
Message 3 of 9 in “[BUG] git gui blame fails for multi-word textconv filter”
  1. Kirill SmelkovAug 4, 2010
  2. Clément PoulainAug 4, 2010
  3. Matthieu MoyAug 5, 2010
  4. git-gui: Use shell to launch textconv filter in "blame"Matthieu Moy, Aug 5, 2010
  5. Pat ThoytsAug 5, 2010
  6. Matthieu MoyAug 6, 2010
  7. Pat ThoytsAug 6, 2010
  8. Pat ThoytsAug 5, 2010
  9. Kirill SmelkovAug 19, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.