Re: git interpret-trailers with multiple keys

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Apr 6, 2016, 16:58 UTC
Message-ID: <vpqlh4qbrnt.fsf@anie.imag.fr>
In-Reply-To: <20160406191054-mutt-send-email-mst@redhat.com>

"Michael S. Tsirkin" <mst@redhat.com> writes:

Show 16 quoted lines

> I have this in .git/config
>
> [trailer "r"]
>         key = Reviewed-by
>         command = "echo \"Michael S. Tsirkin <mst@redhat.com\""
> [trailer "s"]
>         key = Signed-off-by
>         command = "echo \"Michael S. Tsirkin <mst@redhat.com\""
>
> whenever I run git interpret-trailers -t r I see these lines added:
>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com
>
> Why is Reviewed-by repeated?  Bug or feature?

The first two lines are added unconditionally:

$ echo | git interpret-trailers

Reviewed-by: Michael S. Tsirkin <mst@redhat.com
Signed-off-by: Michael S. Tsirkin <mst@redhat.com

The last line is added because you've asked for it with --trailer r.

I don't think it's currently possible to get the behavior you seem to expect, ie. to define trailer tokens fully (key and value) in your config file but use them only on request.

(BTW, I think you wanted a closing > at the end)

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/