Re: git with custom diff for commits

From: Matthieu Moy <matthieu.moy@imag.fr>
Date: Dec 18, 2007, 08:57 UTC
Message-ID: <vpqk5ncz8fn.fsf@bauges.imag.fr>
In-Reply-To: <7vbq8o6gxw.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 15 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
>>> It will show an empty output for "git diff", but I doubt thit will 
>>> change anything at commit time. Probably the "filter" thing on the same 
>>> file (also "man gitattributes") can help though.
>>
>> Ah, right.  I completely missed that you were talking about git-commit, 
>> not git-log on git commits.
>>
>> Yes, setting up a "clean" filter that removes the timestamps is probably 
>> the reasonable thing to do here.
>
> I wouldn't do filters for something like that.  Can you guarantee that
> the output from corresopnding smudge filter will load cleanly back to
> the mysql database?

The original poster said the date was an SQL comment, so, it should be safe to strip it. That said, precommit hook is probably a good or better solution. At least, if you're not sure you didn't make a mistake writting it, you'll notice either a good commit or no commit at all. With filters, you might well notice you corrupted the commit too late :-(.

-- 
Matthieu