git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: t7800 test failure

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
May 24, 2016, 16:48 UTC
Message-ID
<vpqk2ijs8p2.fsf@anie.imag.fr>
In-Reply-To
<CALR6jEiJwx14zAyond9ggz29Q64Fz84URtjr8zaddjnrdY7TjA@mail.gmail.com>
Armin Kunaschik <megabreit@googlemail.com> writes:
> t7800 fails on systems where readlink (GNUism?) is not available.

I don't think it's POSIX, but it is present on all POSIX-like systems I know. On which system did you get the issue?

> +readlink() { ls -ld "$1" | sed 's/.* -> //'; }

This is much less robust than the actual readlink. For example, if -> appears in the link name, it breaks.

It would be acceptable as a fall-back if readlink is not present, but shouldn't activate the "ls" hack by default.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Armin KunaschikNext: Junio C Hamano
Message 2 of 14 in “t7800 test failure”
  1. Armin KunaschikMay 24, 2016
  2. Matthieu MoyMay 24, 2016
  3. Junio C HamanoMay 24, 2016
  4. Armin KunaschikMay 24, 2016
  5. Junio C HamanoMay 24, 2016
  6. Armin KunaschikMay 25, 2016
  7. David AguilarMay 27, 2016
  8. Matthieu MoyMay 27, 2016
  9. t7800 readlink not foundArmin Kunaschik, May 31, 2016
  10. Torsten BögershausenMay 31, 2016
  11. Junio C HamanoMay 31, 2016
  12. Armin KunaschikJun 21, 2016
  13. Junio C HamanoJun 21, 2016
  14. Torsten BögershausenJun 21, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.