Re: [PATCH v4 5/5] git-remote-mediawiki: Add preview subcommand into git mw.

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 20, 2013, 08:53 UTC
Message-ID: <vpqip19duxn.fsf@anie.imag.fr>
In-Reply-To: <1371712593-6210-6-git-send-email-benoit.person@ensimag.fr>

benoit.person@ensimag.fr writes:

> +# @TODO : add documentation for verbose option

I guess that's not applicable anymore.

> +distant mediawiki and combined with a template retrieved from the mediawiki.

s/distant/remote/

Show 8 quoted lines

> +sub preview {
> +	my $wiki;
> +	my ($remote_url, $wiki_page_name);
> +	my ($new_content, $template);
> +	my $file_content;
> +
> +	if ($file_name eq EMPTY) {
> +		die "Missing file argument, see `git mw help` \n";

Unneeded space before \n.

Show 5 quoted lines

> +	for (@{ $html_tree->extract_links() }) {
> +		my ($link, $element, $attr) = @{ $_ };
> +		my $url = url($link)->canonical;
> +		$element->attr($attr, URI->new_abs($url, $remote_url));
> +	}

Extracting this into a function like "make_links_absolute" would have made it clearer.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/