git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 2/2] submodule: don't print status output with ignore=all

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Sep 5, 2013, 06:30 UTC
Message-ID
<vpqioyf231e.fsf@anie.imag.fr>
In-Reply-To
<52279ACC.2070308@web.de>
Jens Lehmann <Jens.Lehmann@web.de> writes:
Show 11 quoted lines
> Am 04.09.2013 08:31, schrieb Matthieu Moy:
>> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>> 
>>> Tests are included which verify that this change has no effect on git submodule
>>> summary without the --for-status option.
>> 
>> I still don't understand why this is needed.
>
> To avoid a change in behavior for "git submodule summary", as that
> never honored the submodule.*.ignore nor the diff.ignoreSubmodules
> setting (and I don't think it ever should).

I don't get it. If the goal is to keep the old behavior, then "git status" shouldn't be changed either. Fixing bugs needs to change the behavior.

IOW, why was it a bug that "git status" showed ignored submodules and not a bug that "git submodule summary" did the same?

> Fine by me, what would you propose to clarify that? (Though I have the
> suspicion that the explanation will be three years late ;-)

I have no idea, as I do not understand the reason myself yet. I'm not a frequent user of submodules and not a user of the ignore option at all, so I can't tell what's best. I'd just like the new behavior to be justified somewhere.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Jens LehmannNext: Matthieu Moy
Message 11 of 13 in “submodule: Don't print status output with submodule.<name>.ignore=all”
  1. 0/2 submodule: Don't print status output with submodule.<name>.ignore=allbrian m. carlson, Sep 1, 2013
  2. 1/2 submodule: fix confusing variable namebrian m. carlson, Sep 1, 2013
  3. 2/2 submodule: don't print status output with ignore=allbrian m. carlson, Sep 1, 2013
  4. Jens LehmannSep 3, 2013
  5. Junio C HamanoSep 3, 2013
  6. Jens LehmannSep 4, 2013
  7. Junio C HamanoSep 4, 2013
  8. Jens LehmannSep 4, 2013
  9. Matthieu MoySep 4, 2013
  10. Jens LehmannSep 4, 2013
  11. Matthieu MoySep 5, 2013
  12. Matthieu MoySep 5, 2013
  13. brian m. carlsonSep 6, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.