Re: [PATCH 1/2] reset: allow "-" short hand for previous commit

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Mar 8, 2015, 10:33 UTC
Message-ID: <vpqioeb22y8.fsf@anie.imag.fr>
In-Reply-To: <1425762244-8629-1-git-send-email-sudshekhar02@gmail.com>

Sudhanshu Shekhar <sudshekhar02@gmail.com> writes:

> +		if(!strcmp(argv[0], "-")) {

[...]

Show 10 quoted lines

> diff --git a/builtin/reset.c b/builtin/reset.c
> index 9f8967d..02f33ef 100644
> --- a/builtin/reset.c
> +++ b/builtin/reset.c
> @@ -206,7 +206,7 @@ static void parse_args(struct pathspec *pathspec,
>  	 */
>  
>  	if (argv[0]) {
> -		if(!strcmp(argv[0], "-")) {
> +		if (!strcmp(argv[0], "-")) {

Please, squash this hunk into the previous patch, so that reviewers get the right version right away.

Also, send each patch as a separate email (git send-email can do that for you).

> +	test_must_fail git reset - 2> output &&

Here and elsewhere: no space after >.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/