Re: [WIP PATCH 1/3] git bisect old/new

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 4, 2015, 08:20 UTC
Message-ID: <vpqiob3yjeh.fsf@anie.imag.fr>
In-Reply-To: <1433404753-12039-1-git-send-email-antoine.delaite@ensimag.grenoble-inp.fr>

Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr> writes:

Show 11 quoted lines

> @@ -732,18 +736,25 @@ static void handle_bad_merge_base(void)
>  	if (is_expected_rev(current_bad_oid)) {
>  		char *bad_hex = oid_to_hex(current_bad_oid);
>  		char *good_hex = join_sha1_array_hex(&good_revs, ' ');
> -
> -		fprintf(stderr, "The merge base %s is bad.\n"
> -			"This means the bug has been fixed "
> -			"between %s and [%s].\n",
> -			bad_hex, bad_hex, good_hex);
> -
> +		if (!strcmp(bisect_bad,"bad")) {

space after comma.

Show 6 quoted lines

> @@ -954,6 +994,9 @@ int bisect_next_all(const char *prefix, int no_checkout)
>  	       "(roughly %d step%s)\n", nr, (nr == 1 ? "" : "s"),
>  	       steps, (steps == 1 ? "" : "s"));
>  
> +	free((char*)bisect_bad);
> +	free((char*)bisect_good);

Already noted last time I think: these must not be freed as they are pointing to static strings.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/