git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] commit: make the error message on unmerged entries user-friendly.

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jan 6, 2010, 20:15 UTC
Message-ID
<vpqhbqz6lcr.fsf@bauges.imag.fr>
In-Reply-To
<7vy6kbt2ww.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 16 quoted lines
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
>> They'd use "pull", not merge. Anyway, I did it for commit, merge,
>> pull, revert, cherry-pick. I guess we covered the common cases.
>> The patch seems to have a lot of redundancies, but I think trying to
>> factor this into helper functions would be much more effort than the
>> few cut-and-paste that I had to do, since each instance is a slight
>> variant of each other ...
>
> I'd be more worried about longer term maintainability than one time
> expediency of producing your single patch to add these messages.  If the
> messages are cast in stone, we can just verify they are consistent _now_
> and forget about them, but I suspect not even you are perfect to predict
> that we won't come up with different/better ways to resolve and mark them
> resolved in the future and write a set of messages that won't have to
> change.

Sorry, I sent the message a bit too early. Re-reading the patch, there were actually pieces to factor. There's still duplication between C and shell, and sentences which are actually reworded from a place to another.

OTOH, maybe this reveals some differences that should be eliminated. For example, 'git cherry-pick' has no problem with $GIT_DIR/MERGE_HEAD, while 'git merge' will immediately if it exists. Maybe we should write a helper like ensure_everything_is_ok_for_a_merge_or_die() called by both cherry-pick and merge?

This time, patch actually follows ;-).
-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Junio C HamanoNext: Matthieu Moy
Message 7 of 14 in “commit: make the error message on unmerged entries user-friendly.”
  1. commit: make the error message on unmerged entries user-friendly.Matthieu Moy, Jan 6, 2010
  2. Junio C HamanoJan 6, 2010
  3. Matthieu MoyJan 6, 2010
  4. Junio C HamanoJan 6, 2010
  5. Matthieu MoyJan 6, 2010
  6. Junio C HamanoJan 6, 2010
  7. Matthieu MoyJan 6, 2010
  8. Be more user-friendly when refusing to do something because of conflict.Matthieu Moy, Jan 6, 2010
  9. Be more user-friendly when refusing to do something because of conflict.Matthieu Moy, Jan 6, 2010
  10. Junio C HamanoJan 6, 2010
  11. Matthieu MoyJan 7, 2010
  12. Be more user-friendly when refusing to do something because of conflict.Matthieu Moy, Jan 7, 2010
  13. Be more user-friendly when refusing to do something because of conflict.Matthieu Moy, Jan 7, 2010
  14. Junio C HamanoJan 13, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.