git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Fix false positives in t3404 due to SHELL=/bin/false

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jan 4, 2011, 22:28 UTC
Message-ID
<vpqhbdoxpzp.fsf@bauges.imag.fr>
In-Reply-To
<982E526FA742C94E9AC26DA766FD07090A3399@NYCMBX3.winmail.deshaw.com>
"Vallon, Justin" <Justin.Vallon@deshaw.com> writes:
> How was SHELL=/bin/false causing problems?  Is git using $SHELL?

The explanation is in the comment right above the modification in the patch. "user's shell" can be read as "$SHELL":

Show 10 quoted lines
> --- a/t/t3404-rebase-interactive.sh
> +++ b/t/t3404-rebase-interactive.sh
> @@ -71,8 +71,9 @@ test_expect_success 'setup' '
>  # "exec" commands are ran with the user shell by default, but this may
>  # be non-POSIX. For example, if SHELL=zsh then ">file" doesn't work
>  # to create a file. Unseting SHELL avoids such non-portable behavior
> -# in tests.
> +# in tests. It must be exported for it to take effect where needed.
>  SHELL=
> +export SHELL

(my bad, I wrote this SHELL= without exporting it. Since bash re-exports already exported variables when they are assigned, and my /bin/sh points to bash, I didn't notice)

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Robin H. JohnsonNext: Jonathan Nieder
Message 7 of 11 in “Fix false positives in t3404 due to SHELL=/bin/false”
  1. Fix false positives in t3404 due to SHELL=/bin/falseRobin H. Johnson, Dec 27, 2010
  2. Junio C HamanoDec 27, 2010
  3. Fix false positives in t3404 due to SHELL=/bin/falseRobin H. Johnson, Dec 27, 2010
  4. Junio C HamanoDec 28, 2010
  5. Vallon, JustinJan 4, 2011
  6. Robin H. JohnsonJan 4, 2011
  7. Matthieu MoyJan 4, 2011
  8. Jonathan NiederJan 4, 2011
  9. Junio C HamanoJan 4, 2011
  10. Vallon, JustinJan 5, 2011
  11. Junio C HamanoJan 5, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.