Re: [PATCH] rebase: accept indented comments (fixes regression)

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Sep 30, 2015, 19:50 UTC
Message-ID: <vpqh9mbhek2.fsf@grenoble-inp.fr>
In-Reply-To: <xmqqy4fn7m2s.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> +		pick|p|drop|d|reword|r|edit|e|squash|s|fixup|f)
> +			if ! check_commit_sha "${rest%% *}" "$lineno" "$1"

This does not pass my "tabs" test, as it parses the sha1 out of the line assuming it's separated with a space. It's used in other places of the code, but tabs still seem to work more or less by chance (they are not parsed properly by transform_todo_ids, but then they are understood by do_next).

I changed it to

	while read -r command sha1 rest

which is a bit more lazy.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/