Re: [RFC PATCH] git add -p: new "quit" command at the prompt.

From: Matthieu Moy <matthieu.moy@imag.fr>
Date: Apr 12, 2009, 12:45 UTC
Message-ID: <vpqfxgevy58.fsf@bauges.imag.fr>
In-Reply-To: <7vws9rdmgd.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 11 quoted lines

> Matthieu Moy <Matthieu.Moy@imag.fr> writes:
>
>> There's already 'd' to stop staging hunks in a file, but no command to
>> stop the interactive staging (for the current files and the remaining
>> ones). This patch implements this functionality, and binds it to 'q'.
>> ---
>>
>> I'm not familiar at all with the code in git-add--interactive.perl, so
>> my code is mostly cut-and-pasted+adapted from the 'd' command.
>
> You can say 'd' and then ^C, I think.

Yes, you /can/, and that's what I'm doing right now in this situation. But that's undocumented, not so intuitive (I found out I could do that after trying ^C alone, which doesn't work, staged content is recorded on disk at the end of the file only, not after each prompt), ...

I thought the situation was common enough to deserve an explicit command. The 'd' command is natural for "git add -i" + patch subcommand, but for "git add -p", I found 'd' mostly useless, and I really want a "quit" command.

Sure, I can live without it, but if other people would like to have it, please speak now ;-).

-- 
Matthieu