Re: [PATCH v4] log: add log.follow config option

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jul 9, 2015, 08:38 UTC
Message-ID: <vpqfv4xafpp.fsf@anie.imag.fr>
In-Reply-To: <1436377321-8495-1-git-send-email-dturner@twopensource.com>

David Turner <dturner@twopensource.com> writes:

> This version uses tweak, and also includes Matthieu Moy's suggested
> whitespace fix.

This comment should come below the --- after the commit message (right before the diffstat). Otherwise, Junio will get this as the commit message when applying, and your actual commit message will be ignored.

Show 6 quoted lines

> ---
> Many users prefer to always use --follow with logs.  Rather than
> aliasing the command, an option might be more convenient for some.
>
> Junio C Hamano <gitster@pobox.com> suggested using the tweak
> functionality for this, which is much nicer than what I had before.

I would avoid using "what I had before" in the commit message: readers of "git log" do not know what you had before. OTOH, crediting Junio for the idea is good.

> Signed-off-by: David Turner <dturner@twopensource.com>
> ---

(This is the place for comments)

Show 6 quoted lines

>  Documentation/git-log.txt |  6 ++++++
>  builtin/log.c             | 16 ++++++++++++++++
>  diff.c                    |  5 +++--
>  diff.h                    |  1 +
>  t/t4202-log.sh            | 23 +++++++++++++++++++++++
>  5 files changed, 49 insertions(+), 2 deletions(-)

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/