Re: [PATCH v16 00/14] port tag.c to use ref-filter APIs

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Sep 7, 2015, 14:05 UTC
Message-ID: <vpqfv2qqq7y.fsf@scolette.imag.fr>
In-Reply-To: <CAOLa=ZQFZRKY_hHEVQQ6CuYC9XNWHJFYg1CFZCGUr-68phDMHQ@mail.gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

Show 19 quoted lines

> On Mon, Sep 7, 2015 at 12:03 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>> diff --git a/builtin/tag.c b/builtin/tag.c
>>> index 9fa1400..f55dfda 100644
>>> --- a/builtin/tag.c
>>> +++ b/builtin/tag.c
>>> @@ -43,8 +43,8 @@ static int list_tags(struct ref_filter *filter, struct ref_sorting *sorting, con
>>>
>>>       if (!format) {
>>>               if (filter->lines)
>>> -                     format = to_free = xstrfmt("%%(align:15,left)%%(refname:short)%%(end) %%(contents:lines=%d)",
>>> -                                                filter->lines);
>>> +                     format = to_free = xstrfmt("%%(align:15,left)%%(refname:short)%%(end) "
>>> +                                                "%%(contents:lines=%d)", filter->lines);
>>
>> This line still looks overlong.  Would it help to stop spelling this
>> as a double "a = b = overlong expression" assignment?
>>
>
> I'm not sure, I get what you mean.

I guess

format = xstrfmt("%%(align:15,left)%%(refname:short)%%(end) %%(contents:lines=%d)",
                 filter->lines);
to_free = format;

(still 83 columns + indentation, but that's a bit shorter than your version).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/