Re: [PATCH 0/3] rebase -i: drop, missing commits and static checks
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Jun 30, 2015, 15:39 UTC
- Message-ID
- <vpqegkt434o.fsf@anie.imag.fr>
- In-Reply-To
- <1849903896.89424.1435676774069.JavaMail.zimbra@ensimag.grenoble-inp.fr>
Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr> writes:
Show 6 quoted lines
> Galan Rémi <remi.galan-alfonso@ensimag.grenoble-inp.fr> writes: >> Shouldn't all the checking also be called in a 'rebase --continue', >> considering that it can be called after a 'rebase --edit-todo' ? >> (Right now it is only called after closing the editor in 'rebase -i') > > What's your opinion on it?
It would probably be better to run the check when running "git rebase --continue". This way, we would have a guarantee that the todo-list is syntactically correct when going through it.
Just checking after --edit-todo would not guarantee that:
$ git rebase --edit-todo # Add some syntax errors, save and quit Warning: the command isn't recognized ... # Hmm, let's ignore that warning $ git rebase --continue Unknown command: ... Please fix this using 'git rebase --edit-todo'
But in any case, the most important is the initial edition. It covers 99.9% of use-cases. So, I'd say: if you have time to add the checks at the other relevant places, good, but not doing it shouldn't block the inclusion of the series.
-- Matthieu Moy http://www-verimag.imag.fr/~moy/