Re: [PATCH v17 14/14] tag.c: implement '--merged' and '--no-merged' options
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Sep 18, 2015, 09:13 UTC
- Message-ID
- <vpqeghwks3a.fsf@anie.imag.fr>
- In-Reply-To
- <20150918084208.GJ17201@serenity.lan>
John Keeping <john@keeping.me.uk> writes:
Show 10 quoted lines
> On Fri, Sep 18, 2015 at 09:10:08AM +0200, Matthieu Moy wrote: > >> The `commit` may be omitted and defaults to HEAD if this is the final >> argument. > > I find that slightly confusing, although that might just be me. It's > slightly longer, but I would write: > > The `commit` may be omitted if this is the final argument, in > which case it defaults to `HEAD`.
Probably clearer indeed.
Show 5 quoted lines
> I also had a look at git-branch(1), which has similar `--merged` and > `--no-merged` options and says: > > Only list branches whose tips are reachable from the specified > commit (HEAD if not specified). Implies `--list`.
I think this lacks the "may be omitted if this is the final argument", which is actually the most confusing (see the other thread "git status -u is mildly astonishing" for an example of similar confusion).
-- Matthieu Moy http://www-verimag.imag.fr/~moy/