Re: [PATCH 1/2] send-email: refactor and ensure prompting doesn't loop forever

From: Matthieu Moy <matthieu.moy@imag.fr>
Date: Mar 30, 2009, 11:29 UTC
Message-ID: <vpqd4bzjlk1.fsf@bauges.imag.fr>
In-Reply-To: <1238290751-57461-1-git-send-email-jaysoffian@gmail.com>

Jay Soffian <jaysoffian@gmail.com> writes:

> Several places in send-email prompt for input, and will do so forever
> when the input is EOF. This is poor behavior when send-email is run
> unattended (say from cron).

Thanks a lot for the patch, it does fix the problem I reported in http://article.gmane.org/gmane.comp.version-control.git/114577 .

Minor problem: I still (harmless) get error messages in my log:

  print() on closed filehandle FOUT at /usr/share/perl/5.8/Term/ReadLine.pm line 193.
  readline() on closed filehandle FIN at /usr/share/perl/5.8/Term/ReadLine.pm line 395.
  print() on closed filehandle FOUT at /usr/share/perl/5.8/Term/ReadLine.pm line 203.
  
But I can very well live with them!

-- 
Matthieu