git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] In configure.ac, try -lpthread in $LIBS instead of $CFLAGS to make picky linkers happy

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Nov 6, 2015, 08:25 UTC
Message-ID
<vpqbnb7edqn.fsf@anie.imag.fr>
In-Reply-To
<201511060111.tA61BbFX084361@tezro.nonet>
"Rainer M. Canavan" <git@canavan.de> writes:
> Subject: Re: [PATCH] In configure.ac, try -lpthread in $LIBS instead of $CFLAGS to make picky linkers happy

The patch looks good, but the subject should be improved. We normally try to stick to 50 characters (to let "git log --oneline" fit in a 80 columns terminal). 50 is a bit strict and not always followed, but yours is definitely too long.

Also, the convention is "subsystem: what you did". I'd suggest this:
configure.ac: try -lpthread in $LIBS instead of $CFLAGS

The "to make picky linkers happy" is important, but redundant with the body of the message.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Rainer M. CanavanNext: Rainer M. Canavan
Message 4 of 7 in “configure: -lpthread doesn't belong in CFLAGS”
  1. Rainer M. CanavanNov 1, 2015
  2. Matthieu MoyNov 2, 2015
  3. In configure.ac, try -lpthread in $LIBS instead of $CFLAGS to make picky linkers happyRainer M. Canavan, Nov 6, 2015
  4. Matthieu MoyNov 6, 2015
  5. configure.ac: try -lpthread in $LIBS instead of $CFLAGSRainer M. Canavan, Nov 8, 2015
  6. Matthieu MoyNov 8, 2015
  7. Jeff KingNov 20, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.