git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv6 1/3] git-rebase -i: add command "drop" to remove a commit

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jun 23, 2015, 20:22 UTC
Message-ID
<vpq8ubamaz0.fsf@anie.imag.fr>
In-Reply-To
<392249968.731834.1435087097209.JavaMail.zimbra@ensimag.grenoble-inp.fr>
Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr> writes:
Show 8 quoted lines
> I think that the indentation on its own is enough to avoid confusion
>> test_rebase_end () {
>> 	test_when_finished "git checkout master &&
>> 		git branch -D $1 &&
>> 		test_might_fail git rebase --abort" &&
>> 	git checkout -b $1 master
>> }
> but your idea is fine as well, so I'm ok with either way.

Read too quickly, it looks like a mis-indentation (I could laugh at Eric here, but I made the same confusion when reading the code at first). By "avoid the confusion" I mean "make it clear it's not a mis-indentation".

Anyway, we're just bikeshedding here. Any version is fine with me.
-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Remi Galan AlfonsoNext: Junio C Hamano
Message 10 of 16 in “[PATCHv6 1/3] git-rebase -i: add command "drop" to remove a commit”
  1. Galan RémiJun 22, 2015
  2. 2/3 git rebase -i: warn about removed commitsGalan Rémi, Jun 22, 2015
  3. 3/3 git rebase -i: add static check for commands and SHA-1Galan Rémi, Jun 22, 2015
  4. Junio C HamanoJun 23, 2015
  5. Remi Galan AlfonsoJun 23, 2015
  6. Eric SunshineJun 23, 2015
  7. Remi Galan AlfonsoJun 23, 2015
  8. Matthieu MoyJun 23, 2015
  9. Remi Galan AlfonsoJun 23, 2015
  10. Matthieu MoyJun 23, 2015
  11. Junio C HamanoJun 23, 2015
  12. Remi Galan AlfonsoJun 23, 2015
  13. Eric SunshineJun 23, 2015
  14. Junio C HamanoJun 23, 2015
  15. Remi Galan AlfonsoJun 23, 2015
  16. Junio C HamanoJun 23, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.