Re: [PATCH v9 5/5] bisect: allow any terms set by user

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jun 26, 2015, 17:08 UTC
Message-ID: <vpq8ub6s8hc.fsf@anie.imag.fr>
In-Reply-To: <xmqqtwtuv2jr.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 5 quoted lines

> And worse yet, majority of users may read "git bisect start" is
> where "you start bisection", but "bisect start" (either called
> directly, or via bisect_autostart by the first "git bisect good")
> is where you set up the machinery, so doing "bisect terms" before
> doing "bisect start" does not make much sense.

This is currently how it's implemented. You need to say

$ git bisect terms foo bar $ git bisect start

And indeed "git bisect terms foo bar" errors out. I think the reason it is this way is to allow

$ git bisect terms foo bar $ git bisect start <sha1> <sha1>

But actually, we can allow "git bisect terms" until BISECT_TERMS is created, which is your intuition and makes more sense IMHO. I'll try to do that.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/