Re: [WIP-PATCH 0/2] send-email: refactor the email parser loop

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: May 28, 2016, 15:04 UTC
Message-ID: <vpq8tyujkb0.fsf@anie.imag.fr>
In-Reply-To: <20160527201436.GA16547@dcvr.yhbt.net>

Eric Wong <e@80x24.org> writes:

Show 17 quoted lines

> Samuel GROOT <samuel.groot@grenoble-inp.org> wrote:
>
>>    (mbox) Adding cc: A<author@example.com>  from line 'Cc: A<author@example.com>, One<one@example.com>'
>>    (mbox) Adding cc: One<one@example.com>  from line 'Cc: A<author@example.com>, One<one@example.com>'
>> 
>> Though `git send-email` now outputs something like:
>> 
>>    (mbox) Adding cc: A<author@example.com>  from line 'Cc: A<author@example.com>'
>>    (mbox) Adding cc: One<one@example.com>  from line 'Cc: One<one@example.com>'
> I actually like neither, and would prefer something shorter:
>
>     (mbox) Adding cc: A <author@example.com> from Cc: header
>     (mbox) Adding cc: One <one@example.com> from Cc: header
>     (mbox) Adding cc: SoB <SoB@example.com> from Signed-off-by: trailer
>
> That way, there's no redundant addresses in each line and less
> likely to wrap.

I agree with this. Actually, I'd even say that the current output of "git send-email" looks sloppy, and internal refactoring may be a good opportunity to get it cleaner.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/