Re: [PATCH] contrib/hooks/post-receive-email: get description from repo.git/config
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- May 7, 2013, 07:49 UTC
- Message-ID
- <vpq7gjbrzzz.fsf@grenoble-inp.fr>
- In-Reply-To
- <7vwqrbmh4d.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 9 quoted lines
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes: > >> More precisely: you should have a look at git-multimail (in directory >> contrib/, in branch for now pu/, or from >> https://github.com/mhagger/git-multimail) before spending time on >> post-receive-email. > > Oh, by the way, is this a vote of confidence in that topic, hinting > that we would want to advance it to 'next'?
I definitely would like to see git-multimail in contrib/, and to have it considered as "the recommended way to send emails from a hook". It does all the old script did, and much more.
post-receive-email can stay for people who don't have Python on their servers, or for existing users who don't want to migrate.
My preference would go for a subtree merge to keep the existing history (that would mean extracting a subdirectory of git-multimail's tree before merging it to git.git).
> As it is only adding a new script to contrib/, it could be argued > that we could even push it to 1.8.3-rc1,
OTOH, it's not urgent, people can already use git-multimail by taking it from GitHub.
-- Matthieu Moy http://www-verimag.imag.fr/~moy/