Re: Issue: Mails sent twice if patch is mentioned twice while sending mail.
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Aug 17, 2011, 09:58 UTC
- Message-ID
- <vpq62lwjr52.fsf@bauges.imag.fr>
- In-Reply-To
- <4E4B86F1.2010802@st.com>
vireshk <viresh.kumar@st.com> writes:
> Hi Ram, > > Actually i did this by mistake once and thought git send-email should > have taken care of this. I may be wrong, but it was just an thought.
git send-email could probably issue a warning if the same patch is mentionned twice, but I don't think it's sane to try to silently autocorrect user's mistake.
If users get used to "git send-email 1.patch 1.patch" sending the email only once, then what should be the expected behavior of
git send-email 1.patch ./1.patch
git send-email 1.patch symlink-to-1.patch
?
The nice thing with a warning is that you can't really blame the tool for not issuing a warning, while it can be harmfull to have an autocorrection fail in a real user-senario.
-- Matthieu Moy http://www-verimag.imag.fr/~moy/