Re: GSoC 2016: Microproject

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Feb 19, 2016, 13:03 UTC
Message-ID: <vpq37so26oz.fsf@anie.imag.fr>
In-Reply-To: <CA+DCAeTAmUAciCx33ZHLKReHSy4K-dEeaKSb19qBcQc_U80UJA@mail.gmail.com>

Hi,

This is a double-post. You've posted almost the same message under the title "GSoC 2016". Nothing serious, but attention to details is important if you want to give a good image of yourself.

Mehul Jain <mehul.jain2029@gmail.com> writes:

> Hello everyone,
>
> I'm Mehul Jain. I'm looking for participating in GSoC 2016.

Note that we are just submitting our application, but have no guarantee that the Git organization will be accepted for this year's GSoC.

Show 11 quoted lines

> I've started work on a Microproject" Teach git pull --rebase the
> --no-autostash" option. While looking at Git's source code I have made
> following observation: In the pull.c file
> 1.  git_config_get_bool( , ) search in the configuration key for the
> value of rebase.autostash, if found true then modify autostash's value
> to a non-zero number and thus making a stash to encounter the problem
> of dirty tree.
> 2. Here if in command line a flag "--no-autostash" is given then we
> can easily set the value of autostash = 0 and thus killing the process
> by die_on_unclean_work_tree(prefix).
> Is my observation is right?

I don't have all the code in mind, but I think it is. In this situation, you always end up with a variable telling Git what to do (I guess, autostash here), and this variable is set according to the configuration and the command-line.

You should be careful about the precedence: command-line should override the configuration. And the default behavior should be used if neither the command-line nor the configuration specified otherwise.

To get an example, you can pick any pair (command-line option, config) that work together, find the code implementing it and blame to find the corresponding commit.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/