Re: [PATCH 2/2 v2] verify_filename: ask the caller to chose the kind of diagnosis

>> @@ -80,14 +86,28 @@ static void NORETURN die_verify_filename(const char *prefix, const char *arg)
>>   * as true, because even if such a filename were to exist, we want
>>   * it to be preceded by the "--" marker (or we want the user to
>>   * use a format like "./-filename")
>> + *
>> + * The "diagnose_misspelt_rev" is used to provide a user-friendly
>> + * diagnosis. If 0, the diagnosis will try to diagnose "name" as an
>> + * invalid object name (e.g. HEAD:foo). If non-zero, the diagnosis
>> + * will only complain about an inexisting file.
>
> I have a feeling that "if 0/if non-zero" above are backwards.