Re: [PATCH v2] show-branch: use pager
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Jun 13, 2013, 09:32 UTC
- Message-ID
- <vpq1u86pd8q.fsf@anie.imag.fr>
- In-Reply-To
- <1371110238-6910-1-git-send-email-oystwa@gmail.com>
Øystein Walle <oystwa@gmail.com> writes:
> This is for consistency with other porcelain commands such as 'log'.
I don't think consistency with other porcelain is a sufficient argument. Many commands purposely don't use the pager by default because they will normally have a short output.
Users can already set "pager.show-branch" to get the behavior you introduce in the patch. The question is more: will users prefer having the pager by default for this particular command? I don't use show-branch enough to answer by myself, but probably the answer is yes.
(This is not an objection, just to make sure you have all the elements)
-- Matthieu Moy http://www-verimag.imag.fr/~moy/