Re: [PATCHv3] Makefile: add missing phony target

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Dec 16, 2015, 08:25 UTC
Message-ID: <vpq1tamls0y.fsf@anie.imag.fr>
In-Reply-To: <1450192860-60337-1-git-send-email-gitter.spiros@gmail.com>

Elia Pinto <gitter.spiros@gmail.com> writes:

Show 6 quoted lines

> Add some missing phony target to Makefile.
>
> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
> Helped-by: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
> ---
> This is the third version of this patch.

Thanks. I double-checked with

grep .PHONY Makefile | sed 's/.PHONY: //; s/#.*//' | tr ' ' '\n' | sort | uniq -c | sort -n

there are no duplicate .PHONY, and all .PHONY targets are indeed .PHONY ones, so the patch is now

Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>

> Compared to the previous I have added only the missing phony 
> target as suggested by Matthieu Moy

Note: my comments were not meant to be an objection to the additional
refactoring. At least some of the hunks definitely made sense to me, but
they are better done in a separate patch.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/