Re: [PATCH] Add Tru64/OSF1 support in Makefile

From: Tor Arntsen <tor@spacetec.no>
Date: Apr 2, 2010, 14:07 UTC
Message-ID: <u2ld2d39d861004020707m7577182et40b4cd6b93bae830@mail.gmail.com>
In-Reply-To: <DA8Or5TA0_betHA0BMcLIT0so7oVjDK6CYr4x1LCiX60SEmuPqVnXg@cipher.nrlssc.navy.mil>

On Wed, Mar 31, 2010 at 18:29, Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil> wrote:

> On 03/30/2010 01:22 PM, Tor Arntsen wrote:
>> This patch to Makefile makes git build for me on Tru64/OSF1 V5.1 with
>> the native compiler.

[..]

Show 14 quoted lines

>> +ifeq ($(uname_S),OSF1)
>> +     # Tested with V5.1 w/libcurl and zlib-1.1.4-5 in /usr/local/
>> +     CC = cc
>> +     CFLAGS = -O2 -g3
>
> I wonder if the native compiler will be the most common compiler
> used on this platform?  I tend to lean towards configuring the
> Makefile for gcc, unless gcc is not available for a platform. The
> user can set CC and CFLAGS in config.mak and on the make command
> line if they desire something different.
>
> This isn't an objection by me, I'm just mentioning it to bring
> attention to the issue in case others think it is worthy for
> git to have a stated policy one way or the other.

I'm not certain. I do in fact have gcc (3.3) installed on this Tru64 box, but it doesn't seem to be part of the original 'freeware' CD that used to come with Tru64. Besides, the freeware CD was first removed as physical CD, and later (two or three years ago, apparently) pulled by HP from the online download which was used by their 'tachometer' ('apt-get'-like) freeware tool. Tru64 V51B (which seems to be the latest, there's no 5.2 as I originally thought) is still available for download, and so is the native compiler. As far as I can tell it's incredibly difficult to find precompiled freeware/oss packages for Tru64 anymore.

Show 5 quoted lines

>> +     SHELL_PATH = /bin/ksh
>
> Can you run the test suite with this ksh?  If it suffers from
> the same exit status behavior of ksh on IRIX and SunOS, then
> I have a patch which allows the test suite to run.

Good idea. I'll do that, and maybe that would indicate if there are issues with using the native compiler as well.

> Also, I wonder if it suffers from the same trap handling that
> ksh has on SunOS.

[..] I tested that snippet you provided, and it exits with 0 on Tru64 (I also verified that indeed it doesn't on Solaris 10).

Show 5 quoted lines

>> +     BASIC_CFLAGS += -D_POSIX_C_SOURCE=1 -D_OSF_SOURCE=1
>> +     BASIC_CFLAGS += -pthread
>
> There is a PTHREAD_LIBS variable and it seems there is precedent
> for setting it to -pthread in the FreeBSD section.

Right, I can do it similarly in my next version of the patch. Thanks for your comments!

-Tor