Re: cogito-0.10 broken for cg-commit < logmessagefile

From: Catalin Marinas <catalin.marinas@arm.com>
Date: Jun 8, 2005, 16:28 UTC
Message-ID: <tnxhdg8g6e1.fsf@arm.com>
In-Reply-To: <20050608144632.A28042@flint.arm.linux.org.uk>

Russell King <rmk@arm.linux.org.uk> wrote:

> The command in the subject prepends the log message with a blank line.
> This ain't good because it messes up commit messages as per Linus'
> requirements (the first line must be a summary.)

The patch below should fix the problem. There is no point in writing the status information in a file which is read from stdin.

-- 
Catalin



Fix the log file when read from stdin

Log messages read from stdin shouldn't have additional lines.

Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>

diff --git a/cg-commit b/cg-commit
--- a/cg-commit
+++ b/cg-commit
@@ -215,7 +215,7 @@ if tty -s; then
 		fi
 	fi
 else
-	cat >>$LOGMSG2
+	cat >$LOGMSG2
 fi
 # Remove heading and trailing blank lines.
 grep -v ^CG: $LOGMSG2 | git-stripspace >$LOGMSG