Re: [PATCH v4 3/3] add -p: ignore dirty submodules

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 2, 2022, 08:53 UTC
Message-ID: <sq60608q-2179-1737-q987-736o14s1731q@tzk.qr>
In-Reply-To: <xmqqo7vzax2u.fsf@gitster.g>

Hi Junio,

On Thu, 1 Sep 2022, Junio C Hamano wrote:

Show 13 quoted lines

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > Thanks to alwyas running `diff-index` and `diff-files` with the
>
> "always".
>
> I notice that this round (like the previous one, v3) is made not to
> apply on 'maint'.  As I said in the earlier review, in general I
> prefer to fork a bugfix topic out of 'maint' unless there is a
> strong reason not to.

Sorry, I thought that your comment was more about changing the base commit too often, not meant as "please change it back for your next iteration".

I have changed it back, fixed the typo and force-pushed. In case a new iteration is still required, that iteration will have these changes.

Ciao, Dscho

Show 10 quoted lines

> It is a different matter if all these bugfix topics are actually
> merged down to 'maint' and tagged a new maintenance release by me.
> But I'd prefer to make it easier for motivated distro packagers to
> adopt fixes that proves good in our 'master' front to their maint
> releases, and it would be much easier to just merge a topic based on
> 'maint' than having to cherry-pick a topic based on 'master'.
>
> Thanks.
>
>