Re: [PATCH] config option core.showroot to enable showing the diff of the root commit
- From
- Peter Baumann <peter.b.baumann@stud.informatik.uni-erlangen.de>
- Date
- Nov 23, 2006, 23:34 UTC
- Message-ID
- <slrnemcc0b.ncc.Peter.B.Baumann@xp.machine.xx>
- In-Reply-To
- <7virh5khrc.fsf@assigned-by-dhcp.cox.net>
On 2006-11-23, Junio C Hamano <junkio@cox.net> wrote:
Show 16 quoted lines
> Peter Baumann <Peter.B.Baumann@stud.informatik.uni-erlangen.de> > writes: > >> This allows one to see the root commit as a diff in commands like git-log, >> git-show and git-whatchanged. It also modifies git-diff-tree to act as --root >> was specified on the commandline. The default is set to true. >> >> Signed-off-by: Peter Baumann <Peter.B.Baumannn@stud.informatik.uni-erlangen.de> >> --- >> I'm not sure if making core.showroot acting on git-diff-tree is the >> right thing to do. Please check first bevore applying. > > I agree that this "use --root by default" belongs to Porcelain > layer, not the plumbing. We would probably want to do this in > the same way as we do the color in diff.c::git_diff_ui_config(). >
Sorry, but I don't understand. The color handling doesn't look any different to me than the handling of the other config entrys. Did I miss something?
Peter