Re: [PATCH 1/6] ci: deduplicate calls to `apt-get update`

From: Justin Tobler <jltobler@gmail.com>
Date: Oct 14, 2025, 20:56 UTC
Message-ID: <rxdwxiokqn2vak4sm7yxzisolbugzr26ygcq4mue3fu5lmmfra@r2pj355wu5mf>
In-Reply-To: <20251007-b4-pks-ci-rust-v1-1-394502abe7ea@pks.im>

On 25/10/07 02:36PM, Patrick Steinhardt wrote:

Show 9 quoted lines

> When installing dependencies we first check for the distribution that is
> in use and then we check for the specific job. In the first step we
> already install all dependencies required to build and test Git, whereas
> the second step installs a couple of additional dependencies that are
> only required to perform job-specific tasks.
> 
> In both steps we use `apt-get update` to update our repository sources.
> This is unecessary though: all platforms that use Aptitude would have
> already executed this command in the distro-specific step anyway.

The distro-specific setup always executes first and does make these call redundant. Make sense.

Not related to this change, but at a glance it looks like this job specific setup relies on using an Aptitude based distro. This does seem slightly fragile if a job were to be configured with an unsupported distro. Not anything we need to change here though.

-Justin