Re: Question about PERL_PATH
- From
Robin H. Johnson <robbat2@gentoo.org>
- Date
- May 7, 2011, 18:02 UTC
- Message-ID
- <robbat2-20110507T174237-068953557Z@orbis-terrarum.net>
- In-Reply-To
- <7v7ha33jd7.fsf@alter.siamese.dyndns.org>
On Fri, May 06, 2011 at 09:05:08AM -0700, Junio C Hamano wrote:
Show 7 quoted lines
> The variable is not PERL_COMMAND_LINE, but is PERL_PATH, so I think it > should expects the path to the program. > > Our testsuite also rely on it being the path to the program by enclosing > the reference to it inside double quotes, to make sure that PERL_PATH set > to "/Program Files/Perl/perl.exe" works. Didn't Gentoo folks see any test > breakage before shipping the ebuild procedure?
The entire test suite completes fine with our PERL_PATH="${EPREFIX}/usr/bin/env perl" setting.
This was originally put into place because of our bug #326625 [1]. From that bug: ==== Git does not compile if local::lib installed in user's home directory if 'sudo' is used to raise privileges. Local::lib exports environment variable PERL5_MM_OPTS, which contains string INSTALL_BASE='...'. Variable PREFIX is set in package's Makefile.pl. Package will not compile if both of these variables are set. ==== (Full logs attached in the bug).
If you can suggest a better way to fix the user's bug, I'll revert the PERL_PATH change.
1. https://bugs.gentoo.org/show_bug.cgi?id=326625
-- Robin Hugh Johnson Gentoo Linux: Developer, Trustee & Infrastructure Lead E-Mail : robbat2@gentoo.org GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85