git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Makefile: Solaris needs HAVE_ALLOCA_H for alloca()

From
Brandon Casey <casey@nrlssc.navy.mil>
Date
Jun 19, 2009, 15:10 UTC
Message-ID
<rIbngkOg09-z417RR6vnxtaWRxZPW0C76uXa4_JzMol0RO1rkm5yNuoSLJ-0CLFvD_NocmuiasU@cipher.nrlssc.navy.mil>
In-Reply-To
<7vy6rpmeqh.fsf@alter.siamese.dyndns.org>
From: Brandon Casey <drafnel@gmail.com>
Signed-off-by: Brandon Casey <drafnel@gmail.com>
---
Junio C Hamano wrote:
Show 5 quoted lines
> ----------------------------------------------------------------
> [New Topics]
> * jk/use-our-regexp (Tue Jun 16 15:08:21 2009 -0400) 2 commits
>  - Makefile: use compat regex on Solaris
>  - Makefile: refactor regex compat support
Please squash this on top of 'Makefile: use compat regex on Solaris'.

There is special handling in compat/regex/regex.c for the GNU compiler to define alloca to __builtin_alloca, but the native compiler must include alloca.h which happens when HAVE_ALLOCA_H is defined.

thanks, -brandon

 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile b/Makefile
index 3bd0c08..bbc26e8 100644
--- a/Makefile
+++ b/Makefile
@@ -753,7 +753,7 @@ ifeq ($(uname_S),SunOS)
 	endif
 	INSTALL = /usr/ucb/install
 	TAR = gtar
-	BASIC_CFLAGS += -D__EXTENSIONS__ -D__sun__
+	BASIC_CFLAGS += -D__EXTENSIONS__ -D__sun__ -DHAVE_ALLOCA_H
 endif
 ifeq ($(uname_O),Cygwin)
 	NO_D_TYPE_IN_DIRENT = YesPlease
-- 
1.6.3.1.24.g152f4
Previous: Junio C Hamano
Message 2 of 2 in “What's cooking in git.git (Jun 2009, #02; Thu, 18)”
  1. Junio C HamanoJun 18, 2009
  2. Makefile: Solaris needs HAVE_ALLOCA_H for alloca()Brandon Casey, Jun 19, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.