Re: [PATCH] More flexible URL patterns for gitweb
- From
- Damien Tournoud <damien@tournoud.net>
- Date
- Apr 11, 2010, 17:46 UTC
- Message-ID
- <r2te821df551004111046v2ef3219x5c012af27f2cc974@mail.gmail.com>
- In-Reply-To
- <m37hodhp3e.fsf@localhost.localdomain>
On Sun, Apr 11, 2010 at 7:33 PM, Jakub Narebski <jnareb@gmail.com> wrote:
Show 9 quoted lines
> To not break backward compatibility, wouldn't it be better to check if
> elements of @git_base_url_list end with ':' or '/', and join base with
> project path depending on this condition, i.e.:
>
> + @url_list = map { m/[/:]$/ ? "$_$project" : "$_/$project" } @git_base_url_list
> + unless @url_list;
>
> This means: if base ends with colon ':' or slash '/', concatenate base
> and project path, otherwise join them using '/' as field separator.Thanks for the review. Indeed this way sounds better.
All this is new to me so I'm not sure what is the way forward. Should I publish another patch or would you?
Damien Tournoud