Re: [PATCH/RFC] Hacky version of a glob() driven config include
- From
Ping Yin <pkufranky@gmail.com>
- Date
- May 8, 2010, 09:03 UTC
- Message-ID
- <r2i46dff0321005080203m65cb8acak750f4ef46bf4d6e8@mail.gmail.com>
- In-Reply-To
- <201005081018.59757.jnareb@gmail.com>
On Sat, May 8, 2010 at 4:18 PM, Jakub Narebski <jnareb@gmail.com> wrote:
Show 15 quoted lines
> > On Sat, 8 May 2010, Ping Yin wrote: > > > > > > But perhaps we can break backwards compatibility here. I don't know... > > > > > I think we can. Because config file is not in repository, so if your > > older git doesn't support it, you should not use this new syntax. > > Actually per-repository $GIT_DIR/config file *is* in repository... but > is not distributed (it is not transferred on clone / fetch). > > The problem with breaking backwards compatibility is when repository is > on shared filesystem (be it networked filesystem such as NFS or > CIFS/Samba share, or portable USB (pen)drive), and can be accessed by > different versions of git.
You are right, i missed this case. However, If NFS is used, the git version is very likely the same. So i think this case is not worth the effort to keep the backwards compatibility.
> > The '@INCLUDE = db_config.ini' is taken from OpenInteract2::Config::Ini.
I prefer "include foo" which is used by apache, and "@include foo" which doesn't fail to parse when foo doesn't exist.