[PATCH v2] clone/fetch: anonymize URLs in the reflog

From: Johannes Schindelin <johannes.schindelin@gmx.de>

Even if we strongly discourage putting credentials into the URLs passed via the command-line, there _is_ support for that, and users _do_ do that.

Let's scrub them before writing them to the reflog.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
    Anonymize URLs in the reflog
    
    This came up in an internal audit, but we do not consider this to be a
    big deal: the reflog is local and not really shared with anybody.
    
    Changes since v1:
    
     * Changed the if...else if...else cadence to move the die() to the last
       arm
     * Stopped the memory leak of display_repo (allocated by 
       transport_anonymize_url())

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-797%2Fdscho%2Fanonymize-clone-reflog-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-797/dscho/anonymize-clone-reflog-v2
Pull-Request: https://github.com/git/git/pull/797

Range-diff vs v1:

 1:  11c0d47c95e ! 1:  933a7353847 clone/fetch: anonymize URLs in the reflog
     @@ Commit message
          Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
      
       ## builtin/clone.c ##
     -@@ builtin/clone.c: static int path_exists(const char *path)
     - int cmd_clone(int argc, const char **argv, const char *prefix)
     +@@ builtin/clone.c: int cmd_clone(int argc, const char **argv, const char *prefix)
       {
       	int is_bundle = 0, is_local;
     --	const char *repo_name, *repo, *work_tree, *git_dir;
     -+	const char *repo_name, *repo, *display_repo, *work_tree, *git_dir;
     - 	char *path, *dir;
     + 	const char *repo_name, *repo, *work_tree, *git_dir;
     +-	char *path, *dir;
     ++	char *path, *dir, *display_repo = NULL;
       	int dest_exists;
       	const struct ref *refs, *remote_head;
     + 	const struct ref *remote_head_points_at;
      @@ builtin/clone.c: int cmd_clone(int argc, const char **argv, const char *prefix)
     - 
       	path = get_repo_path(repo_name, &is_bundle);
       	if (path)
     --		repo = absolute_pathdup(repo_name);
     -+		display_repo = repo = absolute_pathdup(repo_name);
     - 	else if (!strchr(repo_name, ':'))
     - 		die(_("repository '%s' does not exist"), repo_name);
     + 		repo = absolute_pathdup(repo_name);
     +-	else if (!strchr(repo_name, ':'))
     +-		die(_("repository '%s' does not exist"), repo_name);
      -	else
     -+	else {
     ++	else if (strchr(repo_name, ':')) {
       		repo = repo_name;
      +		display_repo = transport_anonymize_url(repo);
     -+	}
     ++	} else
     ++		die(_("repository '%s' does not exist"), repo_name);
       
       	/* no need to be strict, transport_set_option() will validate it again */
       	if (option_depth && atoi(option_depth) < 1)
     @@ builtin/clone.c: int cmd_clone(int argc, const char **argv, const char *prefix)
       			"an empty directory."), dir);
       
      -	strbuf_addf(&reflog_msg, "clone: from %s", repo);
     -+	strbuf_addf(&reflog_msg, "clone: from %s", display_repo);
     ++	strbuf_addf(&reflog_msg, "clone: from %s",
     ++		    display_repo ? display_repo : repo);
     ++	free(display_repo);
       
       	if (option_bare)
       		work_tree = NULL;

 builtin/clone.c            | 13 ++++++++-----
 builtin/fetch.c            |  9 +++++++--
 t/t5541-http-push-smart.sh | 15 +++++++++++++++
 3 files changed, 30 insertions(+), 7 deletions(-)